Fixed naming issues and added conventions #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seriva
commented
Oct 3, 2019
•
seriva
commented
- validator fixes
- prefix field validation
- cluster name field validation
- cluster_tag fix
- new way of generating storage_account names on azure
- unit tests
- validator fixes - prefix field validation - cluster name field validation - cluster tag fixes
toszo
approved these changes
Oct 4, 2019
to-bar
approved these changes
Oct 4, 2019
to-bar
changed the title
to-bar
pushed a commit
to to-bar/epiphany
that referenced
this pull request
May 6, 2020
* Fixed naming issues and added conventions: - validator fixes - prefix field validation - cluster name field validation - cluster tag fixes * Minor update for storage account naming and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.