Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Task Remove swap from /etc/fstab does not remove swap entry from file #2989

Closed
7 of 18 tasks
plirglo opened this issue Feb 22, 2022 · 1 comment
Closed
7 of 18 tasks
Assignees
Labels

Comments

@plirglo
Copy link
Contributor

plirglo commented Feb 22, 2022

Describe the bug
Test if remove swap task works correctly on every supported platform. On Ubuntu 18.04 task does not remove swap entry.

How to reproduce
Steps to reproduce the behavior:

  1. execute epicli apply ...
  2. confirm in /etc/fstab if swap is disabled

Expected behavior
According to task swap entry should be removed, and swap should be disabled after reboot.

Config files
N/A

Environment

  • Cloud provider: [None]
  • OS: Ubuntu 18.04 / 20.04 (vagrant's generic/ubuntu) but should be similar on other platforms

epicli version: 1.2

Example:
This is how /etc/fstab file looks like on vagrant's generic/ubuntu2004:

image

none instead swap in mount point column causes that no changes will be done by existing task.

Create backport task to v1.0 before close this one
Backport task: #2993


DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
@plirglo plirglo changed the title [BUG] Task remove swap does not remove swap entry [BUG] Task Remove swap from /etc/fstab does not remove swap entry from file Feb 24, 2022
@plirglo plirglo self-assigned this Feb 28, 2022
@przemyslavic przemyslavic self-assigned this Mar 1, 2022
@przemyslavic
Copy link
Collaborator

✔️ Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants