Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Extend K8s config validation #2812

Closed
9 of 20 tasks
atsikham opened this issue Dec 22, 2021 · 2 comments
Closed
9 of 20 tasks

[FEATURE REQUEST] Extend K8s config validation #2812

atsikham opened this issue Dec 22, 2021 · 2 comments

Comments

@atsikham
Copy link
Contributor

atsikham commented Dec 22, 2021

Is your feature request related to a problem? Please describe.
Right now K8s validation doesn't cover all configuration parameters that we have, so it's even possible to place there some parameters that we don't support, but they will be applied, for example, if they are valid for kubeadm config.

Describe the solution you'd like
Extend validation.

Describe alternatives you've considered
No.

Additional context
Other validation configurations might be checked in addition.

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@atsikham
Copy link
Contributor Author

As discussed with @seriva, there is no possibility for now to check additional fields and that's done by purpose and such behavior was requested before.

@przemyslavic przemyslavic self-assigned this Feb 4, 2022
@przemyslavic
Copy link
Collaborator

✔️ Validation for kubernetes_master component verified.

@seriva seriva closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants