Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Skip download images if custom_registry provided #2736

Closed
20 tasks
rafzei opened this issue Nov 3, 2021 · 2 comments
Closed
20 tasks

[FEATURE REQUEST] Skip download images if custom_registry provided #2736

rafzei opened this issue Nov 3, 2021 · 2 comments
Labels
area/ansible area/development area/repository status/grooming-needed type/improvement

Comments

@rafzei
Copy link
Contributor

rafzei commented Nov 3, 2021 •
edited by seriva
Loading

Is your feature request related to a problem? Please describe.
Currently, if you provide custom_registry IP address in shared_config all k8s deployments will use that for images source.
In that case, the repository machine will be created obviously, but with unnecessary the images part.

Describe the solution you'd like
Refactor repository role to do not download images if custom_registry is in place.
In addition, check why ansible creates [image_registry] group in inventory pointing to the repository machine (and if we can change that)

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@rafzei
Copy link
Contributor Author

rafzei commented Nov 5, 2021

This could be done right after #805

@seriva
Copy link
Collaborator

seriva commented Nov 16, 2022

Not going todo anymore feature requests for Epiphany.

@seriva seriva closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ansible area/development area/repository status/grooming-needed type/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seriva @rafzei