Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non critical error in epicli if no 'path' is provided #2542

Closed
5 of 10 tasks
rafzei opened this issue Sep 2, 2021 · 1 comment
Closed
5 of 10 tasks

[BUG] Non critical error in epicli if no 'path' is provided #2542

rafzei opened this issue Sep 2, 2021 · 1 comment
Assignees
Labels
python Pull requests that update Python code type/bug
Milestone

Comments

@rafzei
Copy link
Contributor

rafzei commented Sep 2, 2021

Describe the bug
I faced the issue in devcontainer:

vscode@c91ba3ea365b:/workspaces/epiphany/core/src/epicli$ epicli --version
1.2.0dev
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/genericpath.py", line 19, in exists
    os.stat(path)
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

It also occurs with any help (usage) message.

How to reproduce
Steps to reproduce the behavior in devcontainer:

  1. alias epicli="PYTHONPATH=$(pwd) python3 cli/epicli.py"
  2. execute epicli --version, epicli init -h ... or any different --help

Expected behavior
No error message

*epicli version: [epicli --version]
1.2.0dev


DoD checklist

  • Changelog updated (if affected version was released)
  • COMPONENTS.md updated / doesn't need to be updated
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Case covered by automated test (if possible)
  • Idempotency tested
  • Documentation updated / doesn't need to be updated
  • All conversations in PR resolved
  • Backport tasks created / doesn't need to be backported
@rafzei rafzei added type/bug status/grooming-needed python Pull requests that update Python code labels Sep 2, 2021
@seriva seriva added this to the Improvements milestone Sep 2, 2021
@seriva seriva self-assigned this Sep 2, 2021
@przemyslavic przemyslavic self-assigned this Sep 7, 2021
@przemyslavic
Copy link
Collaborator

Fixed.
Also added the possibility to run epicli commands directly from the terminal, without having to use a debugger ❤️

vscode@25a37e0ee9e8:/workspaces/epiphany/core/src/epicli$ epicli --version
1.2.0dev
vscode@25a37e0ee9e8:/workspaces/epiphany/core/src/epicli$ epicli init -h
usage: epicli <command> [<args>] init [-h] -p {aws,azure,any} -n NAME [--full]

Creates configuration file in working directory.

required arguments:
  -p {aws,azure,any}, --provider {aws,azure,any}
                        One of the supported providers: azure|aws|any
  -n NAME, --name NAME  Name of the cluster.

optional arguments:
  -h, --help            show this help message and exit
  --full                Use this flag if you want to create verbose
                        configuration file.

@mkyc mkyc closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code type/bug
Projects
None yet
Development

No branches or pull requests

4 participants