Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 unit tests that are marked to be skipped during test execution #2521

Closed
10 of 13 tasks
przemyslavic opened this issue Aug 27, 2021 · 1 comment
Closed
10 of 13 tasks
Assignees
Labels
area/testing python Pull requests that update Python code

Comments

@przemyslavic
Copy link
Collaborator

przemyslavic commented Aug 27, 2021

Is your feature request related to a problem? Please describe.
We have two unit tests that have been skipped from testing for a long time.

  • test_get_autoscaling_group_should_set_proper_values_to_model
    @pytest.mark.skip(reason='Rewrite this test regarding subnets')

  • test_get_launch_configuration_should_set_proper_values_to_model
    @pytest.mark.skip(reason='Rewrite this test regarding security groups')

Describe the solution you'd like
Tests should be rewritten/ adjusted to current conditions and included in the test suite.

Describe alternatives you've considered
If these tests are of no use, they can be removed.

Additional context
It is important to fix this as test results are presented in the Text Exit Summary Report.


DoD checklist

  • Changelog updated
  • COMPONENTS.md updated / doesn't need to be updated
  • Schema updated / doesn't need to be updated
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Idempotency tested
  • Documentation added / updated / doesn't need to be updated
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
  • Backport tasks created / doesn't need to be backported
@przemyslavic przemyslavic added status/grooming-needed area/testing python Pull requests that update Python code labels Aug 27, 2021
@seriva seriva self-assigned this Aug 27, 2021
@seriva seriva changed the title [FEATURE REQUEST] Rewrite 2 unit tests that are marked to be skipped during test execution [FEATURE REQUEST] Fix 2 unit tests that are marked to be skipped during test execution Aug 27, 2021
@seriva seriva changed the title [FEATURE REQUEST] Fix 2 unit tests that are marked to be skipped during test execution Fix 2 unit tests that are marked to be skipped during test execution Aug 27, 2021
@przemyslavic
Copy link
Collaborator Author

Some of the existing tests were fixed/refactored and new ones were added.

image.png

@przemyslavic przemyslavic self-assigned this Aug 31, 2021
@mkyc mkyc closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

3 participants