Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPGRADE] Upgrade of PgBouncer [standalone] #2453

Closed
10 of 12 tasks
plirglo opened this issue Jul 22, 2021 · 2 comments
Closed
10 of 12 tasks

[UPGRADE] Upgrade of PgBouncer [standalone] #2453

plirglo opened this issue Jul 22, 2021 · 2 comments
Assignees

Comments

@plirglo
Copy link
Contributor

plirglo commented Jul 22, 2021

Is your feature request related to a problem? Please describe.
We need to upgrade PgBouncer if possible and needed to the newer version. This task should be done after we will upgrade PostgreSQL to v13.
This task applies to standalone application

Describe the solution you'd like
We want to upgrade if possible and needed to the newer version of PgBouncer.

Describe alternatives you've considered
None.

Additional context
This task should be done after upgrade of PostgreSQL to v13.


DoD checklist

  • Changelog updated
  • COMPONENTS.md updated / doesn't need to be updated
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Idempotency tested
  • Documentation added / updated / doesn't need to be updated
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
  • Backport tasks created / doesn't need to be backported
@przemyslavic
Copy link
Collaborator

@atsikham @to-bar @plirglo

  1. Why do we install pgbouncer on all postgresql nodes and configure it only on one (first)?.
  2. After re-runnig epicli apply command the order of the nodes may change, which will result in having pgbouncer configured on the master node (from the first run) and then configured on the second node pointing to a replica (on the second run), which may cause issues when running quries in a read-only transaction.
- name: Extensions | configure PgBouncer
  when: groups.postgresql[0] == inventory_hostname
  1. Also during the upgrade, we start the pgbouncer service on both nodes, even if one of them has not been properly configured before.
    - name: PostgreSQL | Extensions | PgBouncer | Upgrade
      when: pg_is_pgbouncer_used
      block:
        - include_tasks: roles/postgresql/tasks/upgrade/extensions/pgbouncer/packages.yml

        - name: Extensions | PgBouncer | Ensure that systemd service is started
          systemd:
            name: pgbouncer
            state: started

I know that from the next version we will not support such an installation of pgbouncer, so if there is no point in fixing it, please just comment here.

@plirglo
Copy link
Contributor Author

plirglo commented Sep 2, 2021

Let's leave it as it is since we plan to deprecate this feature. It's old bug and as far as i know no one is using this configuration, since we deliver more mature configuration based on pgbouncer/pgpool in k8s. It was used when we supported PostgreSQL native replication, but we don't support it anymore.

@seriva seriva closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants