Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Ability to use "long lasting" Kubernetes certificates - 0.6.x backport #1679

Closed
mkyc opened this issue Sep 17, 2020 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@mkyc
Copy link
Contributor

mkyc commented Sep 17, 2020

Is your feature request related to a problem?
By design Kubernetes assumes all newly created certificates have expiration time set to 1 year. There is really no automatic way to overcome that and modify expiration time.

Describe the solution you'd like
This issue is already fixed and implemented in task #1302 and we would like to backport it to 0.6.x and test it.

---
kind: configuration/kubernetes-master
title: "Kubernetes Master Config"
name: default
provider: azure
specification:
  advanced:
    certificates:
      location: /etc/kubernetes/pki
      expiration_days: 800
      renew: false

Recommended tests:

  • single machine, single-master and HA installations
  • parameter values: renew: true, renew: false with different periods, including default
  • new installations using running epicli apply for the second time after changing parameters

Describe alternatives you've considered
it's possible to renew certs by kubeadm manually: kubeadm alpha certs renew apiserver, but we don't want to do it manually
kubeadm alpha certs renew apiserver

Additional context
These changes can be modified to work without openssl_* modules, with shell.

@mkyc mkyc changed the title [BACKPORT] Ability to use "long lasting" Kubernetes certificates - backport to 0.6.x [BACKPORT] Ability to use "long lasting" Kubernetes certificates - 0.6.x backport Sep 17, 2020
@mkyc mkyc added this to the S20201105 milestone Oct 22, 2020
@atsikham atsikham self-assigned this Oct 26, 2020
@atsikham
Copy link
Contributor

Please also test limits for expiration_days. Schema validation should work with that.

@mkyc mkyc modified the milestones: S20201105, S20201119 Nov 5, 2020
@przemyslavic przemyslavic self-assigned this Nov 6, 2020
@przemyslavic
Copy link
Collaborator

Tested:
✅ single machine
✅ single master + nodes
✅ HA installation
✅ parameter values: renew: true, renew: false
✅ different expiration_days, including default, custom and maximum (24855 days ~ 68 years)
✅ running epicli apply for the second time after changing parameters

No problems encountered ✔️

@mkyc mkyc closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants