Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multisig make methods #1546

Closed
janniks opened this issue Sep 5, 2023 · 0 comments
Closed

fix multisig make methods #1546

janniks opened this issue Sep 5, 2023 · 0 comments
Assignees
@janniks
Labels
bug Unwanted or unintended logic causing harm

Comments

@janniks
Copy link
Collaborator

janniks commented Sep 5, 2023

Multisig is being done incorrectly for a long time (for the makeXYZ methods 😬
Right now it only works if the first n-all signers sign (ie are in the signers array)
The manual sign or append flow works, but the makeXZY functions don’t if there is a “hole” (eg 2/3 with 1 and 3 signing)
@janniks janniks added the bug Unwanted or unintended logic causing harm label Sep 5, 2023
@janniks janniks self-assigned this Sep 5, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Sep 5, 2023
@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools Sep 11, 2023
@smcclellan smcclellan moved this from 📋 Backlog to 👀 In Review in DevTools Jun 27, 2024
@smcclellan smcclellan moved this from 👀 In Review to ✅ Done in DevTools Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janniks janniks

Labels
bug Unwanted or unintended logic causing harm
Projects
DevTools
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janniks @smcclellan