Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added new dsign sys colors #1860

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: added new dsign sys colors #1860

wants to merge 1 commit into from
+171 −1

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Oct 15, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adding colors for the new design system.
I added them as a separate file so that its easy to differentiate the old and new colors and remove the old colors when they are no longer necessary.

Issue ticket number and link

#1841

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:02am
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:02am

@BLuEScioN BLuEScioN requested a review from He1DAr October 15, 2024 22:49
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stories/Colors.stories.tsx 0.00% 11 Missing ⚠️

📢 Thoughts on this report? Let us know!

@BLuEScioN BLuEScioN linked an issue Oct 16, 2024 that may be closed by this pull request
Design system: Implement colors #1841
Open
@BLuEScioN BLuEScioN mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresgalante andresgalante andresgalante left review comments

@He1DAr He1DAr He1DAr approved these changes

@ginny-d ginny-d Awaiting requested review from ginny-d

Assignees
No one assigned
Labels
None yet
Projects
Stacks Explorer
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design system: Implement colors
3 participants
@BLuEScioN @andresgalante @He1DAr