-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add event index to transaction events #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janniks
approved these changes
Feb 12, 2024
MicaiahReid
temporarily deployed
to
Development-testnet
February 12, 2024 19:59
— with
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-mainnet
February 12, 2024 22:12
— with
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
February 12, 2024 22:12
— with
GitHub Actions
Inactive
MicaiahReid
had a problem deploying
to
Staging-mainnet
February 12, 2024 22:13
— with
GitHub Actions
Error
MicaiahReid
had a problem deploying
to
Staging-testnet
February 12, 2024 22:13
— with
GitHub Actions
Error
MicaiahReid
temporarily deployed
to
Development-mainnet
February 13, 2024 21:15
— with
GitHub Actions
Inactive
MicaiahReid
temporarily deployed
to
Development-testnet
February 13, 2024 21:15
— with
GitHub Actions
Inactive
MicaiahReid
had a problem deploying
to
Staging-mainnet
February 13, 2024 21:57
— with
GitHub Actions
Failure
MicaiahReid
had a problem deploying
to
Staging-testnet
February 13, 2024 21:57
— with
GitHub Actions
Failure
MicaiahReid
added a commit
that referenced
this pull request
Feb 14, 2024
(this PR is just cherry-picking the relevant commits from @janniks in PR #417, which I apparently mucked up with some bad merging) - closes #387 - adds a position struct to the event and renames the event to payload (with enum type) - updates occurences.json to include the expected serialized position for testing --- **Note**: Any users running a Chainhook node (i.e. `chainhook service start ...`) will not have transaction event positions stored in the database, so all event position will have a value of: ``` JSON "position": { "index": 0 } ``` To rebuild the database with this data filled in: - Upgrade to the latest version of Chainhook - Delete the `stacks.rocksdb` folder inside the `working_dir` set in your `Chainhook.toml` - Rerun Chainhook This will rebuild your Stacks database from scratch. --------- Co-authored-by: janniks <[email protected]>
vabanaerytk
added a commit
to vabanaerytk/chainhook
that referenced
this pull request
Aug 7, 2024
## [1.3.1](hirosystems/chainhook@v1.3.0...v1.3.1) (2024-02-14) ### Bug Fixes * add event index to transaction events ([#495](hirosystems/chainhook#495)) ([2d2760d](hirosystems/chainhook@2d2760d)), closes [#417](hirosystems/chainhook#417) [#387](hirosystems/chainhook#387) * correctly determine PoX vs PoB block commitments ([#499](hirosystems/chainhook#499)) ([6816e76](hirosystems/chainhook@6816e76)), closes [#496](hirosystems/chainhook#496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this PR is just cherry-picking the relevant commits from @janniks in PR #417, which I apparently mucked up with some bad merging)
event_index
in Stacks transaction event metadata #387Note: Any users running a Chainhook node (i.e.
chainhook service start ...
) will not have transaction event positions stored in the database, so all event position will have a value of:To rebuild the database with this data filled in:
stacks.rocksdb
folder inside theworking_dir
set in yourChainhook.toml
This will rebuild your Stacks database from scratch.