Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events can be added to buffer despite the session being expired #9

Open
hiroshinishio opened this issue Oct 5, 2024 · 2 comments
Open
Labels

Comments

@hiroshinishio
Copy link
Owner

Still investigating, but we are getting event buffer issues because expired sessions are not properly ending the session.
handleException is causing a possible infinite loop of sorts for expired sessions. it eventually ends up calling addEvent() which only checks if replay is paused or ended and not if session is valid. This causes a buildup in the buffer.

e.g. user idles on the page and replay continues to try to flush after the session has ended. Session is not ending properly so buffer continues to grow in size and continues to flush.

This also causes a replay with canvas recordings because resets will cause a new web worker to initialize leading to browser crashes (Closes: getsentry#13743)

Copy link

gitauto-ai bot commented Oct 5, 2024

Click the checkbox below to generate a PR!

  • Generate PR

@hiroshinishio, You have 5 requests left in this cycle which refreshes on 2024-11-04 02:56:25+00:00.
If you have any questions or concerns, please contact us at [email protected].

Copy link

gitauto-ai bot commented Oct 5, 2024

Sorry, we have an error. Please try again.

Have feedback or need help?
Feel free to email [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant