Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to set setDisplayName to false #52

Open
leepowelldev opened this issue Jul 5, 2021 · 0 comments
Open

Not possible to set setDisplayName to false #52

leepowelldev opened this issue Jul 5, 2021 · 0 comments

Comments

@leepowelldev
Copy link

setDisplayName: setDisplayName || true,

Because of the use of the logical or operator here it is not possible to pass false as an option. Passing false incorrectly results in setDisplayName being set to true. Instead I would recommend using the nullish coalescing operator instead (or some similar approach).

Happy to put in a PR if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant