-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support webpack 5 #30
Comments
Happy to test out to help confirm any proposed solutions 😄 |
Hey @hipstersmoothie! This issue is the biggest blocker on Storybook's move to webpack5 and we've called in the big guns, @bebraw, to help us with the upgrade. For simplicity, our current plan is a major version bump of this library that supports webpack5 and drops webpack4 support. We are also looking at a couple other stretch optimizations, and hope to have something working in the next couple weeks. Does that all sound reasonable? Should we we create a PR to this repo, or would you rather we forked this into the Storybook org, since we're probably the biggest user of the library by far. We appreciate your tremendous work on getting this to where it is (and the rest of your contributions to Storybook!), and are happy to introduce the changes in whatever way you're comfortable with. Please let us know what works for you! |
@shilman seems that it could be webpack 4 compatible. I opened draft PR #32 based on storybookjs/storybook#14118 (comment) I think that I can finish it on this weekend |
🚀 Issue was released in |
Relates to storybookjs/storybook#14118
Storybook has enabled experimental support for webpack5 in
6.2
.react-docgen-typescript-plugin
does not seem to work properly with webpack 5 enabled.The text was updated successfully, but these errors were encountered: