Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.1 #24

Open
TeoTN opened this issue Dec 8, 2020 · 1 comment
Open

Typescript 4.1 #24

TeoTN opened this issue Dec 8, 2020 · 1 comment

Comments

@TeoTN
Copy link

TeoTN commented Dec 8, 2020

It seems not to work with Typescript 4.1. The stack trace refers only to typescript paths but disabling the plugin in storybook has made it pass.

70% sealing React Docgen Typescript Plugin /Volumes/unix/.../node_modules/typescript/lib/typescript.js:2229
        return str.lastIndexOf(prefix, 0) === 0;
                   ^

TypeError: Cannot read property 'lastIndexOf' of undefined
    at Object.startsWith (/Volumes/unix/workplace/.../node_modules/typescript/lib/typescript.js:2229:20)
@hipstersmoothie
Copy link
Owner

Could you provide a reproduction repo? None of the libraries (this plugin + react-docgen-typescript) directly depend on typescript. You should be able to edit the yarn.lock file to make sure only 1 version is present in your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants