Review: 'Invisible Mode Overlay'

[bengtan]

The 'Invisible Mode Overlay' (see https://zpl.io/29RKLmW) is probably out of date. The text probably needs changing, or maybe ... Do we even still want it?

cc @thescurry @irfirl @mstidham

[irfirl]

We can update the text and icon to something like this?
Option 1: https://zpl.io/bApnmyn
Options 2: When they're in invisible mode we would fade out the friend icons on the banner to this https://zpl.io/aX8XLxK, and tapping on the banner would bring up the popup https://zpl.io/Vxer8x3

[bengtan]

Option 2 looks nice but I vote for Option 1 as it's a much simpler text change.

[bengtan]

Whoops, I forgot to follow up on this.

Hmmm ... can we get rid of the overlay? Does it still serve a purpose?

Yesterday, I was debugging some stuff related to invisible mode and the overlay just got in my way. Yes, it prevented me from using the header widget but I could still access the user-in-the-header-widget-I-was-looking-for by going to my list of Friends.

So the header widget didn't actually prevent me from doing anything. I was able to do what I wanted ... just that it was more troublesome to do it.

@thescurry @irfirl @mstidham ?

[irfirl]

I think the overlay is still useful for telling the user why they're not seeing others' locations if they're in ghost mode. Unless we're talking about options 2 above which would take them to another popup when they tap on a user portrait.

[bengtan]

@irfirl:

I think the overlay is still useful for telling the user why they're not seeing others' locations if they're in ghost mode.

It used to be the case that, if you were in invisible/hidden/ghost mode, you wouldn't see the locations of people who were sharing to you.

It's not the case anymore.

[thescurry]

I think the overlay is helpful in letting the user know they are in invisible mode, but I think it needs to be changed. The reasoning is, now that we have gotten rid of the "current location" cta, we need the top header to allow the user to return to current location (by tapping on their avatar).

Because of this, I think option 2 (of the two options discussed) is the best way forward. That said, we could come up with an option 3-4, but we need to keep in mind that we should be able to tap on the users avatar to return to "current location".

@irfirl any comments on this?

[irfirl]

@thescurry Ah yes, I think in that case option 2 would be better.