Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] [dev] Update modules that were patched for AndroidX compatibility #3837

Closed
16 of 23 tasks
southerneer opened this issue Jun 19, 2019 · 6 comments
Closed
16 of 23 tasks

Comments

@southerneer
Copy link
Contributor

southerneer commented Jun 19, 2019

for #3832 we patched a bunch of packages. Eventually all of these packages will update their Android dependencies to AndroidX style. We should update our dependencies accordingly (and remove associated patches).

@southerneer
Copy link
Contributor Author

@bengtan @aksonov this will probably be a gradual process rather than solved in one PR. We shouldn't pursue this until after the upcoming iOS release.

@southerneer southerneer changed the title update modules that were patched for AndroidX compatibility [dev] update modules that were patched for AndroidX compatibility Jul 8, 2019
@bengtan
Copy link
Contributor

bengtan commented Jul 9, 2019

@southerneer:

What's your plan for this?

Are you going to do one iteration of trying to upgrade/patch as many modules listed (in the OP) as possible?


Ticket #3789 might overlap with this.

@bengtan bengtan changed the title [dev] update modules that were patched for AndroidX compatibility [android] [dev] Update modules that were patched for AndroidX compatibility Jul 9, 2019
@southerneer
Copy link
Contributor Author

I was thinking of doing a pass over each module in the list and pick off the ones that are easy upgrades (like bugsnag). Presumably there will be some that still lack AndroidX compatibility and may not make sense to upgrade...I'll create separate tickets for those to either check in the future or do the upgrade work in a fork and submit as an upstream PR.

@southerneer
Copy link
Contributor Author

@mstidham this one isn't directly QA-able, we're basically just trying to avoid regressions or lost functionality. I smoke-tested all of the updates, but will await your results too. Push notifications I would pay the most attention to.

@bengtan
Copy link
Contributor

bengtan commented Aug 6, 2019

Moving this back to Ready because there's some more follow-up dev work.

@bengtan
Copy link
Contributor

bengtan commented Sep 27, 2019

@southerneer: What do you think of closing this ticket?

Most of this work is done, and with dependabot, we'll eventually update all the remaining ones ... eventually.

Yes, there is still work to be done, but we don't really need a dedicated ticket (ie. this one) to track it, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants