-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] [dev] Update modules that were patched for AndroidX compatibility #3837
Comments
What's your plan for this? Are you going to do one iteration of trying to upgrade/patch as many modules listed (in the OP) as possible? Ticket #3789 might overlap with this. |
I was thinking of doing a pass over each module in the list and pick off the ones that are easy upgrades (like bugsnag). Presumably there will be some that still lack AndroidX compatibility and may not make sense to upgrade...I'll create separate tickets for those to either check in the future or do the upgrade work in a fork and submit as an upstream PR. |
@mstidham this one isn't directly QA-able, we're basically just trying to avoid regressions or lost functionality. I smoke-tested all of the updates, but will await your results too. Push notifications I would pay the most attention to. |
Moving this back to Ready because there's some more follow-up dev work. |
@southerneer: What do you think of closing this ticket? Most of this work is done, and with dependabot, we'll eventually update all the remaining ones ... eventually. Yes, there is still work to be done, but we don't really need a dedicated ticket (ie. this one) to track it, I think. |
for #3832 we patched a bunch of packages. Eventually all of these packages will update their Android dependencies to AndroidX style. We should update our dependencies accordingly (and remove associated patches).
androidx
suppport. itinance/react-native-fs#691jetifier
to run well against rn-maps, but no updates specifically for AndroidX compatibilityjetifier
and had positive feedback from the repo maintainers.The text was updated successfully, but these errors were encountered: