Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate fix for #58 #59

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Alternate fix for #58 #59

merged 1 commit into from
Sep 9, 2024

Conversation

hildjj
Copy link
Owner

@hildjj hildjj commented Sep 8, 2024

Use package-extract to create pkg.js

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c9b10fe) to head (5edf34d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines         1299      1302    +3     
=========================================
+ Hits          1299      1302    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hildjj
Copy link
Owner Author

hildjj commented Sep 8, 2024

@goodwise, please review, will this work for you instead of #58?

@hildjj hildjj merged commit 9a6ada3 into main Sep 9, 2024
3 checks passed
@hildjj hildjj deleted the package-extract branch September 9, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants