Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for #38 #55

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix types for #38 #55

merged 1 commit into from
Sep 6, 2024

Conversation

hildjj
Copy link
Owner

@hildjj hildjj commented Sep 5, 2024

No description provided.

@hildjj
Copy link
Owner Author

hildjj commented Sep 5, 2024

@gnarea please review

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (53be53a) to head (017341e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         1177      1172    -5     
=========================================
- Hits          1177      1172    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gnarea gnarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hildjj! 🙇🏾

Looks good to me. I also tested it in my codebase, after running npm run types on a local copy, and it all worked!

@hildjj hildjj merged commit 9baac1a into main Sep 6, 2024
3 checks passed
@hildjj hildjj deleted the dnsCheckingDisabled branch September 6, 2024 12:12
@hildjj
Copy link
Owner Author

hildjj commented Sep 6, 2024

v6.0.1 released.

@gnarea
Copy link
Contributor

gnarea commented Sep 6, 2024

Thanks @hildjj! Much appreciated 🙇🏾 Everything works now! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants