Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NITRO_BASIC attribute to PremiumType #1988

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Add NITRO_BASIC attribute to PremiumType #1988

merged 4 commits into from
Aug 4, 2024

Conversation

st1xkz
Copy link
Contributor

@st1xkz st1xkz commented Aug 2, 2024

Summary

Add NITRO_BASIC attribute to PremiumType since there were only NITRO and NITRO_CLASSIC

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

davfsa
davfsa requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

The changelog fragment is missing, but should be a quick addition :)

hikari/users.py Outdated Show resolved Hide resolved
@davfsa davfsa added the enhancement New feature or request label Aug 3, 2024
davfsa
davfsa reviewed Aug 4, 2024
View reviewed changes
hikari/users.py Outdated Show resolved Hide resolved
@davfsa davfsa enabled auto-merge (squash) August 4, 2024 12:30
@davfsa davfsa merged commit a7e09a8 into hikari-py:master Aug 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st1xkz @davfsa