Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle initial opcode as being RECONNECT #1867

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Properly handle initial opcode as being RECONNECT #1867

merged 2 commits into from
Apr 7, 2024

Conversation

beagold
Copy link
Contributor

@beagold beagold commented Apr 2, 2024

Summary

We'll send an opcode 7 instead of hello if a node is trying to drain as you connect to it (i.e. the load balancer hasn't realized it's draining yet). We've been deploying gateway more frequently lately, so it's more likely to be getting it.

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

None

@beagold beagold added the bug Something isn't working label Apr 2, 2024
@beagold beagold self-assigned this Apr 2, 2024
hypergonial
hypergonial reviewed Apr 2, 2024
View reviewed changes
hikari/impl/shard.py Outdated Show resolved Hide resolved
@beagold beagold merged commit 3b087c3 into master Apr 7, 2024
48 checks passed
@beagold beagold deleted the handle-reconnect-as-initial-opcode branch April 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypergonial hypergonial hypergonial left review comments

@FasterSpeeding FasterSpeeding FasterSpeeding approved these changes

Assignees

@beagold beagold

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beagold @FasterSpeeding @hypergonial