Allow changing guild features (community, etc.) #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MutableGuildFeature for features that could be changed instead of relying on library users to look up the official docs - Add corresponding arguments in edit_guild()-s - Update relevant docstrings and tests
davfsa
reviewed
Jan 30, 2024
This is for:
- Consistency: Hikari's approach is "generally not enforcing what can
and can't be passed". `MutableGuildFeature` goes against
such approach.
- Maintenance: `MutableGuildFeature` means constantly babysitting the
official API for changes to what is and isn't mutable,
generating additional workload.
davfsa
reviewed
Feb 21, 2024
Signed-off-by: davfsa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two missing mutable guild features to
GuildFeatureenums, introducesMutableGuildFeaturefor ease of use, and afeaturesargument toedit_guild()to address the lack of support for editing guild features. Relevant docstrings and tests had been updated accordingly.Checklist
noxand all the pipelines have passed.Related issues
Resolves #1768.
Partially addresses #1827.