Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

禁止删除包含绑定了路由的服务的服务来源 #224

Open
CH3CHO opened this issue Jun 7, 2023 · 1 comment
Open

禁止删除包含绑定了路由的服务的服务来源 #224

CH3CHO opened this issue Jun 7, 2023 · 1 comment
Labels
backend enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed level/easy

Comments

@CH3CHO
Copy link
Collaborator

CH3CHO commented Jun 7, 2023

Why do you need it?

如果一个服务来源提供的服务绑定了一个路由，用户又删除了这个服务来源，相应的服务所对应的服务器列表将不再更新，这就可能会影响线上流量。

How could it be?

在删除一个满足上述条件的服务来源时，API 应返回错误信息，告知用户该服务来源已经绑定了路由，不可删除。

但目前看从 Pilot 提供的 /debug/registryz 和 /debug/endpointShardz 似乎没有办法获知各个服务所关联的服务来源。所以具体的判断方法还需要进一步确认。

Other related information
@CH3CHO CH3CHO added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed backend level/easy labels Jun 7, 2023
@CH3CHO
Copy link
Collaborator Author

CH3CHO commented Jun 7, 2023

@johnlanni 麻烦帮忙看看我们现在有办法在 Pilot 接口中拿到各个服务所对应的 MCP 服务来源名称吗？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed level/easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CH3CHO