Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪣 Convert forum actions to framework commands #7203

Closed
Tracked by #6802
rbennettcw opened this issue Mar 21, 2024 · 6 comments
Closed
Tracked by #6802

🪣 Convert forum actions to framework commands #7203

rbennettcw opened this issue Mar 21, 2024 · 6 comments
Assignees

Comments

@rbennettcw
Copy link
Contributor

rbennettcw commented Mar 21, 2024

Child of #6802

Currently, most core functionality is implemented in controllers. We need to start refactoring the logic to conform to the DDD framework.

Create commands for the following actions:

Commands

NOTE: Event emission should not be coupled to the model. Create a nice framework convention for it.

@rbennettcw
Copy link
Contributor Author

@Rotorsoft I've created this ticket to track the creation of the commands. I've prioritized the forum commands since they represent core functionality. However I recall you mentioned Mixpanel in #6802?

@rbennettcw rbennettcw changed the title Convert forum actions to framework commands 🪣 Convert forum actions to framework commands Mar 21, 2024
@Rotorsoft
Copy link
Contributor

yes, probably most of them are already on this list, but make sure to tag them.... and don't miss any other event emitters getting tracked in mixpanel - searching the enum should help

@rbennettcw
Copy link
Contributor Author

This child tickets now represent all commands that are exposed via the API. Might be others that I missed if there are cronjobs or event-driven actions.

Will flesh out the child tickets incrementally as needed.

@rbennettcw
Copy link
Contributor Author

@Rotorsoft – Per previous discussion, we should identify which commands/entities should be prioritized for the Contest work.

@Rotorsoft
Copy link
Contributor

@rbennettcw you can find the model linked to #6824. The contest worker policy will react to thread creation and voting events (initially), so you should focus on the refactoring of these two commands and publishing the events (using a reusable pattern for future commands - we discussed a sequelize hook, but maybe we can create some reusable utilities here).

In summary:

Create Thread
React on Thread

You can confirm the names with the product team... I think we are using "react on thread" to represent future reactions, not just upvoting.

@jnaviask jnaviask added the S2 Sprint 2 label Aug 26, 2024
@rbennettcw
Copy link
Contributor Author

Since we're building the new API gradually and releasing in phases + tracked by other tickets, it no longer makes sense to keep this ticket around.

@rbennettcw rbennettcw closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants