-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪣 Convert forum actions to framework commands #7203
Comments
@Rotorsoft I've created this ticket to track the creation of the commands. I've prioritized the forum commands since they represent core functionality. However I recall you mentioned Mixpanel in #6802? |
yes, probably most of them are already on this list, but make sure to tag them.... and don't miss any other event emitters getting tracked in mixpanel - searching the enum should help |
This child tickets now represent all commands that are exposed via the API. Might be others that I missed if there are cronjobs or event-driven actions. Will flesh out the child tickets incrementally as needed. |
@Rotorsoft – Per previous discussion, we should identify which commands/entities should be prioritized for the Contest work. |
@rbennettcw you can find the model linked to #6824. The contest worker policy will react to thread creation and voting events (initially), so you should focus on the refactoring of these two commands and publishing the events (using a reusable pattern for future commands - we discussed a sequelize hook, but maybe we can create some reusable utilities here). In summary: You can confirm the names with the product team... I think we are using "react on thread" to represent future reactions, not just upvoting. |
Since we're building the new API gradually and releasing in phases + tracked by other tickets, it no longer makes sense to keep this ticket around. |
Child of #6802
Currently, most core functionality is implemented in controllers. We need to start refactoring the logic to conform to the DDD framework.
Create commands for the following actions:
Commands
NOTE: Event emission should not be coupled to the model. Create a nice framework convention for it.
The text was updated successfully, but these errors were encountered: