Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic wallet prompts should only be shown when magic wallet is being used #10374

Open
Israellund opened this issue Dec 18, 2024 · 0 comments · May be fixed by #10390
Open

Magic wallet prompts should only be shown when magic wallet is being used #10374

Israellund opened this issue Dec 18, 2024 · 0 comments · May be fixed by #10390
Assignees
@Israellund
Labels
1 1-2 hour task bug Something isn't working

Comments

@Israellund
Copy link
Collaborator

Israellund commented Dec 18, 2024 •
edited
Loading

Describe the bug

If a user has multiple wallets connected to one account, there needs to be a better way to differentiate if they're using Magic or not. Currently if a user signed up with sso and was given a magic wallet, then they connect a metamask wallet, they are still shown the magic wallet prompt and when clicked the widget isn't shown. Refer to this slack conversation.
https://commonxyz.slack.com/archives/C052DMYFKDL/p1734547246767119

Investigate accounts that have multiple wallets.
@Israellund Israellund added bug Something isn't working needs estimate labels Dec 18, 2024
@Israellund Israellund self-assigned this Dec 18, 2024
@Israellund Israellund linked a pull request Dec 19, 2024 that will close this issue
Open
@Israellund Israellund added 1 1-2 hour task and removed needs estimate labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Israellund Israellund

Labels
1 1-2 hour task bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

magic wallet prompt only shows when using magic hicommonwealth/commonwealth
1 participant
@Israellund