refactor(react-server): use official encodeReply/decodeReply/decodeAction/decodeFormState + feat: support useActionState
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the title
encodeReply/decodeReplyencodeReply/decodeReply
This was referenced Apr 12, 2024
Closed
hi-ogawa
changed the title
encodeReply/decodeReplyencodeReply/decodeReply/decodeAction
3 tasks
hi-ogawa
changed the title
encodeReply/decodeReply/decodeActionencodeReply/decodeReply/decodeAction/decodeFormState
hi-ogawa
changed the title
encodeReply/decodeReply/decodeAction/decodeFormStateencodeReply/decodeReply
hi-ogawa
changed the title
encodeReply/decodeReplyencodeReply/decodeReply/decodeAction/decodeFormState
hi-ogawa
changed the title
encodeReply/decodeReply/decodeAction/decodeFormStateencodeReply/decodeReply/decodeAction/decodeFormState + feat: support useActionState
hi-ogawa
commented
Apr 19, 2024
Comment on lines
67
to
69
| // TODO: needs to await for hydration formState? | ||
| const initialLayout = | ||
| await reactServerDomClient.createFromReadableStream<ServerRouterData>( |
There was a problem hiding this comment.
TODO: move out action form state from initial ssr stream?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
encode/decodeReplyis not for progressive enhancement and they seem to have a quite different code path from stream case.Well, I'm still not sure why
encodeReply/decodeReplyis necessary whendefaultEncodeFormAction/decodeActionseems to do the same (but maybe only forFormData?).TODO
createServerReference(from react-client)defaultEncodeFormAction, which includesprocessReplyetc...bindanduseAcitonStatefor stream casedecodeActionrefactor(react-server): use officialdecodeAction/decodeFormState#284decodeFormStateuseActionDatawithReact.useActionStatebindin react-clientbindin react-serverActionResulttype