Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-server): silence false warning due to use client #221

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Mar 23, 2024

todo

  • I just silenced in onwarn, but maybe we can make quick transform to remove "use client" after createClientReference is taken care?
    • No, this warning is not from RSC build since RSC build already removes "use clinet" when transforming it to createClientReference.
  • why don't we see the same for "use server" for RSC build? Maybe warning happens only when build chunk's source has directive at the top? (client reference is already a separate dynamic import chunk)

@hi-ogawa hi-ogawa changed the title chore(react-server): silence false warning due to "use client" fix(react-server): silence false warning due to "use client" Mar 23, 2024
@hi-ogawa hi-ogawa mentioned this pull request Mar 23, 2024
69 tasks
@hi-ogawa hi-ogawa changed the title fix(react-server): silence false warning due to "use client" fix(react-server): silence false warning due to use client Mar 23, 2024
@hi-ogawa hi-ogawa marked this pull request as draft March 23, 2024 06:46
@hi-ogawa hi-ogawa marked this pull request as ready for review March 23, 2024 08:23
@hi-ogawa hi-ogawa merged commit 4f036d6 into main Mar 23, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the chore-use-client-warning branch March 23, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant