Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-server): client error boundary for server error #211

Merged
merged 41 commits into from
Mar 22, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Mar 20, 2024

  • (client) error boundary
    • csr
    • two pass ssr
      • Cannot do two-pass SSR? (Even if render two-pass, CSR cannot hydrate it anyway?)
        Does next.js give up SSR and CSR only on 2nd pass?
      • actually giving up SSR is not a big deal in terms of SEO as long it puts <meta>?
    • ssr full csr fallback
      • assets?
      • csr createRoot + render?
    • reset
      • probably need better client-side router + transition integration first?
  • http status code
  • handle not found via error boundary
  • default root error boundary
  • convention
  • cleanup error log
  • test
    • 404, 500
    • browser error
    • reset
  • self-reference workaround until Vite 5.2
  • move off refactoring to a separate PR
  • custom server error payload by extending ReactServerErrorContext
    • test

future

  • error reset
  • redirection as error
  • why extra <div> needed for error boundary?

@hi-ogawa hi-ogawa mentioned this pull request Mar 20, 2024
69 tasks
@hi-ogawa hi-ogawa changed the title feat(react-server): error page feat(react-server): error page convention Mar 20, 2024
@hi-ogawa hi-ogawa changed the title feat(react-server): error page convention feat(react-server): error boundary + two-pass ssr Mar 21, 2024
@hi-ogawa hi-ogawa changed the title feat(react-server): error boundary + two-pass ssr feat(react-server): error boundary + two-pass SSR Mar 21, 2024
@hi-ogawa hi-ogawa changed the title feat(react-server): error boundary + two-pass SSR feat(react-server): error boundary + CSR fallback Mar 21, 2024
@hi-ogawa hi-ogawa changed the title feat(react-server): error boundary + CSR fallback feat(react-server): client error boundary for server error Mar 21, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review March 22, 2024 00:47
@hi-ogawa hi-ogawa merged commit 6d4cbfe into main Mar 22, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the feat-react-server-error-page branch March 22, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant