Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autopep8 inplace is ignoring W292 #551

Closed
ChillarAnand opened this issue Jun 10, 2020 · 2 comments
Closed

autopep8 inplace is ignoring W292 #551

ChillarAnand opened this issue Jun 10, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@ChillarAnand
Copy link

ChillarAnand commented Jun 10, 2020

Command Line

$ echo -n 'import x' > foo.py

$ file foo.py
foo.py: ASCII text, with no line terminators

$ autopep8 --recursive --diff .    
--- original/./foo.py
+++ fixed/./foo.py
@@ -1 +1 @@
-import x
\ No newline at end of file
+import x

$ autopep8 --recursive --in-place .

$ file foo.py
foo.py: ASCII text, with no line terminators

Your Environment

  • Python version: 3.8

  • autopep8 version: autopep8 1.5.3 (pycodestyle: 2.6.0)

  • Platform: macOSX

@hhatto hhatto self-assigned this Jun 10, 2020
@ChillarAnand
Copy link
Author

This seems to happen irrespective of --recursive.

$ echo -n 'import x' > foo.py

$ file foo.py                
foo.py: ASCII text, with no line terminators

$ autopep8 --diff foo.py   
--- original/foo.py
+++ fixed/foo.py
@@ -1 +1 @@
-import x
\ No newline at end of file
+import x

$ autopep8 --in-place foo.py 

$ file foo.py               
foo.py: ASCII text, with no line terminators

@ChillarAnand ChillarAnand changed the title autopep8 inplace recursive is ignoring W292 autopep8 inplace is ignoring W292 Jun 11, 2020
@hhatto hhatto added this to the 1.5.4 milestone Jun 22, 2020
@hhatto hhatto added the bug label Jun 22, 2020
@hhatto
Copy link
Owner

hhatto commented Jun 22, 2020

@ChillarAnand

Thank you for bug reporting.
This problem is fixed in latest master (2ab2ea7)

We plan to release it in version 1.5.4.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants