Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

feat(Accessibility): Makes checkbox/radio accessible. Focus States updated. #90

Merged
merged 6 commits into from
Dec 30, 2019

Conversation

mathewmorris
Copy link
Contributor

@mathewmorris mathewmorris commented Dec 4, 2019

Now when tabbing onto checkbox/radio, you can press space, or any other accessible key combo to check/uncheck the box.

Features:

  • Adds a focus state to Switch, Button, Radio, and Checkboxes.

Breaking Changes:

  • Checkbox and Radio are no longer 100% icons. They both use CSS to shape them. The only icon that is customizable is the checkbox check.
Before After
Kapture 2019-12-04 at 16 33 17 Kapture 2019-12-23 at 11 13 04

Ticket

https://app.asana.com/0/1127722639002160/1148828435323497

@mathewmorris mathewmorris requested a review from a team December 4, 2019 22:33
@ghost ghost requested review from erikshestopal and schlegz December 4, 2019 22:34
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          21       21           
  Lines         458      458           
  Branches       93       93           
=======================================
  Hits          303      303           
  Misses        124      124           
  Partials       31       31
Impacted Files Coverage Δ
src/theme.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53757b...c008a81. Read the comment docs.

@mathewmorris mathewmorris changed the title feat(Checkbox): Makes checkbox accessible feat(Accessibility): Makes checkbox/radio accessible. Focus States updated. Dec 30, 2019
@mathewmorris mathewmorris merged commit 1eecf79 into master Dec 30, 2019
@mathewmorris mathewmorris deleted the feat/checkbox-accessibility branch December 30, 2019 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants