-
Notifications
You must be signed in to change notification settings - Fork 1
fix(Formbot): Validate fields when setting state directly #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
======================================
Coverage 68.5% 68.5%
======================================
Files 22 22
Lines 435 435
Branches 92 92
======================================
Hits 298 298
Misses 107 107
Partials 30 30
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
======================================
Coverage 68.5% 68.5%
======================================
Files 22 22
Lines 435 435
Branches 92 92
======================================
Hits 298 298
Misses 107 107
Partials 30 30
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
======================================
Coverage 68.5% 68.5%
======================================
Files 22 22
Lines 435 435
Branches 92 92
======================================
Hits 298 298
Misses 107 107
Partials 30 30
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
======================================
Coverage 68.5% 68.5%
======================================
Files 22 22
Lines 435 435
Branches 92 92
======================================
Hits 298 298
Misses 107 107
Partials 30 30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find
Summary
Formbot#setValues
to update the field programmaticallyThe issue was twofold:
#setValues
#updateField
in#validateAllFields
wasn't being called with{ validated: false }
, which caused#validateField
to bail when it reached this condition: