Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

feat(Label): Label is now aware of multiline inputs #123

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

kylealwyn
Copy link
Contributor

@kylealwyn kylealwyn commented Jun 10, 2020

The top: 50% attribute was vertically centering the label on floating multiline text areas.

Cropping up in https://github.com/heydoctor/emr/pull/431

CleanShot 2020-06-10 at 08 38 51

@kylealwyn
Copy link
Contributor Author

@albertovillalobos y chromatic no work?

@alextranwork
Copy link
Contributor

line height seems off
Screen Shot 2020-06-10 at 10 54 40 AM

@kylealwyn
Copy link
Contributor Author

@vietnogigoodrx I didn't touch it so 🤷‍♂️ feel free to fix/update with design if you want. need this in to unblock medical history changes.

@kylealwyn kylealwyn merged commit 3b1a17f into master Jun 10, 2020
@kylealwyn kylealwyn deleted the fix/floating-label-multiline branch June 10, 2020 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants