Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix: use max-height for <ModalBody> #107

Merged
merged 1 commit into from
May 13, 2020

Conversation

gerrymi
Copy link
Contributor

@gerrymi gerrymi commented May 13, 2020

Asana Task:
https://app.asana.com/0/1172458003196612/1175644854344246

Apologies, I used height instead of max-height :/

Current Behavior:
Screen Shot 2020-05-13 at 12 03 16 PM
Fixed Behavior:
Screen Shot 2020-05-13 at 12 03 28 PM
Retains Original Intent:
Screen Shot 2020-05-13 at 12 03 35 PM

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          21       21           
  Lines         458      458           
  Branches       93       93           
=======================================
  Hits          303      303           
  Misses        124      124           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10000de...763c26a. Read the comment docs.

@gerrymi gerrymi merged commit 7c3982d into master May 13, 2020
@kylealwyn kylealwyn deleted the fix/use-max-height-for-modal-body branch May 13, 2020 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants