Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(Modal): Add guard to scrollToTop #101

Merged
merged 1 commit into from
Jan 31, 2020
Merged

fix(Modal): Add guard to scrollToTop #101

merged 1 commit into from
Jan 31, 2020

Conversation

choochootrain
Copy link

@choochootrain choochootrain added the bug Something isn't working label Jan 31, 2020
@choochootrain choochootrain requested a review from a team January 31, 2020 19:28
@ghost ghost requested review from erikshestopal and schlegz January 31, 2020 19:28
erikshestopal
erikshestopal reviewed Jan 31, 2020
View reviewed changes
src/Modal/Modal.js
@@ -91,7 +91,7 @@ export function Modal({ children, title, animationDuration, showClose, onClose,
};

const scrollToTop = () => {
if (modalRef.current) {
if (modalRef.current && modalRef.current.scroll) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have optional chaining in molekule?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at the moment

@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          21       21           
  Lines         458      458           
  Branches       93       93           
=======================================
  Hits          303      303           
  Misses        124      124           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15a4c7...fb4a2e9. Read the comment docs.

erikshestopal
erikshestopal approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@erikshestopal erikshestopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@choochootrain choochootrain merged commit 0c613eb into master Jan 31, 2020
@choochootrain choochootrain deleted the fix/modal-scroll branch January 31, 2020 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikshestopal erikshestopal erikshestopal approved these changes

@schlegz schlegz Awaiting requested review from schlegz

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@choochootrain @erikshestopal