fix(button): add argTypes type for children props in button #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esraltintas
requested review from
pappjanos,
derek-heycar,
hcafaq,
emrahsemizheycar and
heyabinanto
esraltintas
changed the title
Pull Request Test Coverage Report for Build 3189296495
💛 - Coveralls |
Coverage report
Test suite run success202 tests passing in 28 suites. Report generated by 🧪jest coverage report action from ea6f333 |
|
Compiled a new version demo. |
heyabinanto
approved these changes
Oct 4, 2022
hcafaq
suggested changes
Oct 4, 2022
Add argTypes type for children props in button
Add argTypes type for children props in chip
esraltintas
force-pushed
the
feat/HEYUI-168-screenshot-updates
branch
from
14d2de7
to
f62856b
Compare
|
Compiled a new version demo. |
add argTypes type for children props in chip
|
Compiled a new version demo. |
hcafaq
approved these changes
Oct 5, 2022
derek-heycar
pushed a commit
that referenced
this pull request
Oct 5, 2022
## [2.0.1](v2.0.0...v2.0.1) (2022-10-05) ### Bug Fixes * **button:** add argTypes type for children props in button ([#90](#90)) ([a5a5d45](a5a5d45))
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Even we pass “children“ prop in our screenshot tests, all screenshots are using default parameter what we set in component stories
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!