Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): export ButtonProps #79

Merged
merged 1 commit into from
Sep 14, 2022
Merged

feat(button): export ButtonProps #79

merged 1 commit into from
Sep 14, 2022

Conversation

mwagdi
Copy link

@mwagdi mwagdi commented Sep 13, 2022 •
edited
Loading

Pull Request

Description

Exports ButtonProps from Button package

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@mwagdi mwagdi self-assigned this Sep 13, 2022
@github-actions
Copy link

Compiled a new version demo.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3043661845

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.507%
Totals Coverage Status
Change from base Build 3036167224: 0.0%
Covered Lines: 698
Relevant Lines: 700
💛 - Coveralls

@github-actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 99.33% 746/751
🟢 Branches 90.38% 94/104
🟢 Functions 97.3% 36/37
🟢 Lines 99.71% 698/700

Test suite run success

155 tests passing in 24 suites.

Report generated by 🧪jest coverage report action from 3f12886

@mwagdi mwagdi marked this pull request as ready for review September 13, 2022 09:09
derek-heycar
derek-heycar reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@derek-heycar derek-heycar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it locally through the npm link or yarn.
Is it works correct ?

@mwagdi
Copy link
Author

mwagdi commented Sep 13, 2022

Did you test it locally through the npm link or yarn. Is it works correct ?

@derek-heycar Tested locally and working as expected 👍

@derek-heycar derek-heycar merged commit a542c9d into main Sep 14, 2022
@derek-heycar derek-heycar deleted the feature/export-button-props branch September 14, 2022 13:57
derek-heycar pushed a commit that referenced this pull request Sep 14, 2022
@semantic-release-bot
chore(release): 1.16.0 [skip ci]
f8297ee 
# [1.16.0](v1.15.0...v1.16.0) (2022-09-14)

### Features

* **button:** add export ButtonProps interface ([#79](#79)) ([a542c9d](a542c9d))
@derek-heycar
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derek-heycar
Copy link
Contributor

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcafaq hcafaq Awaiting requested review from hcafaq

@derek-heycar derek-heycar Awaiting requested review from derek-heycar

Assignees

@mwagdi mwagdi

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwagdi @coveralls @derek-heycar