Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(componentheader): fix stage null check for component header when … #73

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

esraltintas
Copy link
Contributor

@esraltintas esraltintas commented Sep 2, 2022

…status component is used

Fix stage null check for component header when status component is used

Pull Request

Description

  • When we set 0 for stage in ComponentHeader, status seems as 0

Screenshot 2022-09-02 at 09 09 33

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:screenshots - to run snapshot tests

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

…status component is used

Fix stage null check for component header when status component is used
@coveralls
Copy link

coveralls commented Sep 2, 2022

Pull Request Test Coverage Report for Build 2992722414

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.507%

Totals Coverage Status
Change from base Build 2971530719: 0.0%
Covered Lines: 698
Relevant Lines: 700

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 99.33% 746/751
🟢 Branches 90.38% 94/104
🟢 Functions 97.3% 36/37
🟢 Lines 99.71% 698/700

Test suite run success

155 tests passing in 24 suites.

Report generated by 🧪jest coverage report action from 6bbdd38

…tage with 0

Fix stage null check for component header has stage with 0
…tage with 0

Fix stage null check for component header has stage with 0
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Compiled a new version demo.

@derek-heycar derek-heycar merged commit 3b54637 into main Sep 9, 2022
@derek-heycar derek-heycar deleted the HEYUI-150-ComponentHeader-status branch September 9, 2022 12:21
derek-heycar pushed a commit that referenced this pull request Sep 9, 2022
## [1.14.2](v1.14.1...v1.14.2) (2022-09-09)

### Bug Fixes

* fixing  the internal storybook component ComponentHeader for the header of the doc section  ([#73](#73)) ([3b54637](3b54637))
@derek-heycar
Copy link
Contributor

🎉 This PR is included in version 1.14.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants