feat(icons): added updated car icons #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 2932938779
💛 - Coveralls |
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run success122 tests passing in 20 suites. Report generated by 🧪jest coverage report action from 83af439 |
|
@derek-heycar I can't see updated icons right now but Icons start showing up if view-box is updated in svg viewBox="0 0 84 50" |
|
Compiled a new version demo. |
derek-heycar
suggested changes
Aug 24, 2022
resolved |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
…in-icons-component
- @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected]
- @heycar-uikit/[email protected]
derek-heycar
deleted the
feature/HEYUI-141-update-svg-icons-for-cars-in-icons-component
branch
derek-heycar
pushed a commit
that referenced
this pull request
Aug 26, 2022
# [1.13.0](v1.12.0...v1.13.0) (2022-08-26) ### Features * **icons:** added extra icons ([#52](#52)) ([59d3693](59d3693))
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
https://heycar.atlassian.net/jira/software/projects/HEYUI/boards/312?selectedIssue=HEYUI-141
Description
Updated car icons from design: https://www.figma.com/file/rrvkvQEoVTOHa7MzyKSaoz/OTP-Global-Design-System?node-id=1364%3A40607
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:screenshots- to run snapshot testsNew Feature / Bug Fix
Thanks for contributing!