feat/HEYUI-80 Accordion component #51

derek-heycar · 2022-08-16T13:57:56Z

Pull Request

Description

Describe your changes (or add ticket description) and add relevant screenshots

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change

How do I test this

Add steps to test
in bullet point format
preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

npm i – for new NPM dependencies.
npm run lint - to check for linting issues
npm run test - to run unit tests
npm run test:screenshots - to run snapshot tests

New Feature / Bug Fix

Run unit tests to ensure all existing tests are still passing.
Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

- @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected]

added basic implementation of chip component with choice and filter options

added tsconfig

added icon.module.css to put icon styles in a seperate file

updated component.stories with text and removed redundent prop

added snapshot and unit tests for chip component

github-actions · 2022-08-16T14:04:59Z

Compiled a new version demo.

coveralls · 2022-08-16T14:06:12Z

Pull Request Test Coverage Report for Build 2971426610

41 of 43 (95.35%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 98.507%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/accordion/src/Accordion.tsx	21	23	91.3%

Totals
Change from base Build 2949609739:	0.8%
Covered Lines:	698
Relevant Lines:	700

💛 - Coveralls

github-actions · 2022-08-16T14:12:23Z

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/bin/git' failed with exit code 1

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	99.33%	746/751
🟢	Branches	90.38%	94/104
🟢	Functions	97.3%	36/37
🟢	Lines	99.71%	698/700

Test suite run success

155 tests passing in 24 suites.

Report generated by 🧪jest coverage report action from 9e49033

github-actions · 2022-08-17T15:44:59Z

Compiled a new version demo.

Replace the font sets regular, bold, and extra bold. Added extra bold font for the individual import /600 BREAKING CHANGE: Can be changed the width of the font for some of the packages which use the font setting

github-actions · 2022-08-22T14:03:27Z

Compiled a new version demo.

…hey-ui into feature/HEYUI-130-implementation-of-the-chips-component

resolved css lint issues in icon.module.css in chip component

github-actions · 2022-08-29T13:15:41Z

Compiled a new version demo.

packages/accordion/src/styles/default.module.css

github-actions · 2022-08-30T12:36:48Z

Compiled a new version demo.

…/HEYUI-130-implementation-of-the-chips-component

.storybook/utils/componentsResolver.js

github-actions · 2022-09-01T09:07:59Z

Compiled a new version demo.

…' into feat/HEYUI-80-accordion

github-actions · 2022-09-01T10:15:57Z

Compiled a new version demo.

- @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected]

github-actions · 2022-09-01T11:26:02Z

Compiled a new version demo.

github-actions · 2022-09-01T11:42:11Z

Compiled a new version demo.

- @heycar-uikit/[email protected]

# [1.14.0](v1.13.0...v1.14.0) (2022-09-01) ### Features * **collapse:** the first version of the collapse component ([#51](#51)) ([b8d3f3f](b8d3f3f))

derek-heycar · 2022-09-01T12:15:06Z

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

derek-heycar and others added 19 commits August 2, 2022 15:14

feat(collapse): the first version of the collapse component

987e976

fix lint error

a1a1b25

fix main doc example

b9c4520

add extra test for change styles

b895cb1

remove control panel from storybook

4f781c5

Merge branch 'main' into feat/HEYUI-81-accordion-component

3ffbf8d

accordion component

4359f76

feat(chip): add basic implementation of chip component

19086a4

added basic implementation of chip component with choice and filter options

refactor(chip): add tsconfig

e6c39c9

added tsconfig

refactor(chip): refactors styles

067550f

added icon.module.css to put icon styles in a seperate file

docs(chip): updated component.stories

58fc570

updated component.stories with text and removed redundent prop

test(chip): added tests for chip component

1588bb1

added snapshot and unit tests for chip component

fix storybook build

0fef784

Accordion update

a707410

WebpackResolveComponentSourcePlugin example

cefa708

refactor(chip): replaced closeicon with dependency

5dea3d1

Merge branch 'main' into feat/HEYUI-80-accordion

7d1670b

accordion main code

1aa8e66

auto-assign bot requested a review from hcafaq August 16, 2022 13:57

update test and component code

80849fa

derek-heycar added 2 commits August 22, 2022 15:17

feat(fonts): changed the configuration of the fonts

0c9b72c

Replace the font sets regular, bold, and extra bold. Added extra bold font for the individual import /600 BREAKING CHANGE: Can be changed the width of the font for some of the packages which use the font setting

feat(accordion): the first implementation of the Accordion component

fcdb5e2

derek-heycar added 2 commits August 22, 2022 16:51

update sc artefacts

a6409b5

update font weight

7b61de1

hcafaq and others added 3 commits August 28, 2022 21:32

Merge branch 'feat/HEYUI-80-accordion' of https://github.com/hey-car/…

12793aa

…hey-ui into feature/HEYUI-130-implementation-of-the-chips-component

refactor(chip): resolve css lint issues

0a4c494

resolved css lint issues in icon.module.css in chip component

update states and sh images

440113c

mwagdi reviewed Aug 30, 2022

View reviewed changes

packages/accordion/src/styles/default.module.css Outdated Show resolved Hide resolved

remove extra CSS rules for accordion

7e1bc9d

hcafaq added 5 commits September 1, 2022 00:07

feat(chip): added onDelete and onClick callbacks

1f839f5

Merge branch 'main' of https://github.com/hey-car/hey-ui into feature…

d9878f0

…/HEYUI-130-implementation-of-the-chips-component

fix(chip): fix snashot tests for chip

32c28bc

test(chip): update all api screenshot tests for chip

2f20baa

test(chip): add images for sh

c9c7b2d

esraltintas reviewed Sep 1, 2022

View reviewed changes

.storybook/utils/componentsResolver.js Show resolved Hide resolved

Merge branch 'main' into feat/HEYUI-80-accordion

05c5612

Merge branch 'feature/HEYUI-130-implementation-of-the-chips-component…

ab8a932

…' into feat/HEYUI-80-accordion

derek-heycar added 2 commits September 1, 2022 13:14

Change version for the chip component

f0489ea

change status to proposal

4f7cd10

derek-heycar added 2 commits September 1, 2022 13:58

feat(accrordion): updated the README documentation

8696abd

chore: publish

9e49033

- @heycar-uikit/[email protected]

derek-heycar merged commit b8d3f3f into main Sep 1, 2022

derek-heycar deleted the feat/HEYUI-80-accordion branch September 1, 2022 12:07

derek-heycar pushed a commit that referenced this pull request Sep 1, 2022

chore(release): 1.14.0 [skip ci]

af8e713

# [1.14.0](v1.13.0...v1.14.0) (2022-09-01) ### Features * **collapse:** the first version of the collapse component ([#51](#51)) ([b8d3f3f](b8d3f3f))

derek-heycar added the released label Sep 1, 2022

esraltintas assigned derek-heycar Sep 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/HEYUI-80 Accordion component #51

feat/HEYUI-80 Accordion component #51

derek-heycar commented Aug 16, 2022

github-actions bot commented Aug 16, 2022

coveralls commented Aug 16, 2022 •

edited

Loading

github-actions bot commented Aug 16, 2022 •

edited

Loading

github-actions bot commented Aug 17, 2022

github-actions bot commented Aug 22, 2022

github-actions bot commented Aug 29, 2022

github-actions bot commented Aug 30, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

derek-heycar commented Sep 1, 2022

feat/HEYUI-80 Accordion component #51

feat/HEYUI-80 Accordion component #51

Conversation

derek-heycar commented Aug 16, 2022

Pull Request

Description

Type of change

How do I test this

Checklist

Did you remember to take care of the following?

New Feature / Bug Fix

github-actions bot commented Aug 16, 2022

coveralls commented Aug 16, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2971426610

💛 - Coveralls

github-actions bot commented Aug 16, 2022 • edited Loading

Coverage report

Test suite run success

github-actions bot commented Aug 17, 2022

github-actions bot commented Aug 22, 2022

github-actions bot commented Aug 29, 2022

github-actions bot commented Aug 30, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

github-actions bot commented Sep 1, 2022

derek-heycar commented Sep 1, 2022

coveralls commented Aug 16, 2022 •

edited

Loading

github-actions bot commented Aug 16, 2022 •

edited

Loading