feat(slider): slider plus unit tests #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started HEYUI-354
working slider with unit tests HEYUI-354
Pull Request Test Coverage Report for Build 5198764090
💛 - Coveralls |
Coverage report
Show new covered files 🐣
Test suite run success401 tests passing in 56 suites. Report generated by 🧪jest coverage report action from 702acb9 |
|
Compiled a new version demo. |
nathanjamal
commented
Jun 6, 2023
| @@ -5,6 +5,7 @@ module.exports = { | |||
| 'prettier', | |||
| 'airbnb/hooks', | |||
| 'plugin:@typescript-eslint/recommended', | |||
| 'plugin:mdx/recommended', | |||
There was a problem hiding this comment.
Added better linting for mdx files
nathanjamal
commented
Jun 6, 2023
| @@ -125,6 +127,7 @@ | |||
| "eslint-plugin-cypress": "2.12.1", | |||
| "eslint-plugin-import": "2.25.4", | |||
| "eslint-plugin-jsx-a11y": "^6.3.1", | |||
| "eslint-plugin-mdx": "^2.1.0", | |||
There was a problem hiding this comment.
better linting for mdx files
|
Compiled a new version demo. |
|
Compiled a new version demo. |
esraltintas
approved these changes
Jun 8, 2023
supcar
pushed a commit
that referenced
this pull request
Jun 8, 2023
# [8.7.0](v8.6.1...v8.7.0) (2023-06-08) ### Features * **slider:** slider plus unit tests ([#216](#216)) ([4417cdc](4417cdc))
|
🎉 This PR is included in version 8.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
working slider with unit tests
HEYUI-354
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!