Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segmented-buttons): added segmented buttons component #213

Merged
merged 12 commits into from
Jun 5, 2023

Conversation

nathanjamal
Copy link
Collaborator

@nathanjamal nathanjamal commented May 30, 2023

Pull Request

Description

added segmented buttons component

HEYUI-319

Screen.Recording.2023-05-31.at.09.22.09.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@nathanjamal nathanjamal self-assigned this May 30, 2023
@auto-assign auto-assign bot requested a review from esraltintas May 30, 2023 14:41
@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented May 30, 2023

Pull Request Test Coverage Report for Build 5156631875

  • 27 of 28 (96.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 92.417%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/segmented-buttons/src/SegmentedButtons.tsx 15 16 93.75%
Totals Coverage Status
Change from base Build 5142623158: -0.03%
Covered Lines: 1634
Relevant Lines: 1696

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented May 30, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.11% 1830/1904
🟢 Branches 81.76% 511/625
🟢 Functions 82.01% 155/189
🟢 Lines 96.34% 1634/1696
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / SegmentedButtons.tsx
88.24% 33.33% 66.67% 93.75%
🟢
... / SegmentedButtons.mocks.ts
100% 100% 100% 100%

Test suite run success

392 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from 1b804c9

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Compiled a new version demo.

@nathanjamal nathanjamal merged commit 2813359 into main Jun 5, 2023
@nathanjamal nathanjamal deleted the HEYUI-319 branch June 5, 2023 10:05
supcar pushed a commit that referenced this pull request Jun 5, 2023
# [8.6.0](v8.5.0...v8.6.0) (2023-06-05)

### Features

* **segmented-buttons:** added segmented buttons component ([#213](#213)) ([2813359](2813359))
@supcar
Copy link
Collaborator

supcar commented Jun 5, 2023

🎉 This PR is included in version 8.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@supcar supcar added the released label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants