test(review-rating): screenshot tests #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added screen shots tests for each rating score at each size HEYUI-307
|
Compiled a new version demo. |
Coverage report
Show new covered files 🐣
Test suite run success301 tests passing in 44 suites. Report generated by 🧪jest coverage report action from 5ae5ae7 |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
nathanjamal
added a commit
that referenced
this pull request
Apr 18, 2023
* feat(review-rating): added the ReviewRating component Added ReviewRating a component that displays a score from 0 to 10 for a vehicle review. when the compont scroll into the viewport it animates a dail to show the correct score. Component can render at 4 different sizes HEYUI-310 * feat(review-rating): add component added component into this epic branch. updated the dics description line HEYUI-307 * test(review-rating): add unit and snapshot tests (#182) add unit and snapshot tests for reviewRating components and utils HEYUI-311 * test(review-rating): update snapshot tests with constatnt ids by default each review-rating component randomly generates an id for itself. this means that snapshots will be invalid everytime they run. ive now given the components in the test a constant id HEYUI-307 * test(review-rating): screenshot tests (#183) * test(review-rating): screenshot tests added screen shots tests for each rating score at each size HEYUI-307 * update screenshot test * update screenshot test * update screenshot test * update screenshot test * update screenshot test * docs(review-rating): added storybook docs and updated readme (#184) added storybook docs, updated readme, changelog and package.json to be correct HEYUI-313 * fix(review-rating): fix but with donut not rerendering correctly if size is changed fix bug with donut not rerendering correctly if size is changed from S to a larger size. Plus fixed a spelling mistake in snapshot tests HEYUI-307 * docs(review-rating): remove all referances to Accordion Removed references in docs and tests to Accordion, the component folder that was duplicated to make this one HEYUI-307 * fix(review-rating): fixed bug with bg gradient not showing if multiple reviewRatings on a page fixed bug with bg gradient not showing if multiple reviewRatings on a page. also fixed a small styling issue with margins HEYUI-307 * test(header): update test shots updated snap and screen shots HEYUI-307
supcar
pushed a commit
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
added screen shots tests for each rating score at each size
HEYUI-307
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!