Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added missing icons #172

Merged
merged 3 commits into from
Mar 22, 2023
Merged

feat(icons): added missing icons #172

merged 3 commits into from
Mar 22, 2023

Conversation

nathanjamal
Copy link
Collaborator

@nathanjamal nathanjamal commented Mar 20, 2023

Pull Request

Description

Added several icons that were missing from the UI Kit

HEYUI-276

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

Added several icons that were missing from the UI Kit

HEYUI-276
@auto-assign auto-assign bot requested a review from esraltintas March 20, 2023 15:20
@coveralls
Copy link

coveralls commented Mar 20, 2023

Pull Request Test Coverage Report for Build 4481356271

  • 118 of 118 (100.0%) changed or added relevant lines in 30 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.785%

Totals Coverage Status
Change from base Build 4478192663: 0.4%
Covered Lines: 1208
Relevant Lines: 1227

💛 - Coveralls

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Mar 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.92% 1316/1344
🟢 Branches 85.4% 269/315
🟢 Functions 94.79% 91/96
🟢 Lines 98.45% 1208/1227
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Amex.tsx
100% 100% 100% 100%
🟢
... / Bluetooth.tsx
100% 100% 100% 100%
🟢
... / BodyColorBlack.tsx
100% 100% 100% 100%
🟢
... / BodyColorBlue.tsx
100% 100% 100% 100%
🟢
... / BodyColorBrown.tsx
100% 100% 100% 100%
🟢
... / BodyColorGold.tsx
100% 100% 100% 100%
🟢
... / BodyColorGreen.tsx
100% 100% 100% 100%
🟢
... / BodyColorGrey.tsx
100% 100% 100% 100%
🟢
... / BodyColorOrange.tsx
100% 100% 100% 100%
🟢
... / BodyColorRed.tsx
100% 100% 100% 100%
🟢
... / BodyColorSilver.tsx
100% 100% 100% 100%
🟢
... / BodyColorWhite.tsx
100% 100% 100% 100%
🟢
... / BodyColorYellow.tsx
100% 100% 100% 100%
🟢
... / Bonus.tsx
100% 100% 100% 100%
🟢
... / Canada.tsx
100% 100% 100% 100%
🟢
... / CO2.tsx
100% 100% 100% 100%
🟢
... / CustomerService.tsx
100% 100% 100% 100%
🟢
... / Datasheet.tsx
100% 100% 100% 100%
🟢
... / Error.tsx
100% 100% 100% 100%
🟢
... / Euro.tsx
100% 100% 100% 100%
🟢
... / France.tsx
100% 100% 100% 100%
🟢
... / Germany.tsx
100% 100% 100% 100%
🟢
... / Intercom.tsx
100% 100% 100% 100%
🟢
... / Language.tsx
100% 100% 100% 100%
🟢
... / Mastercard.tsx
100% 100% 100% 100%
🟢
... / MOT.tsx
100% 100% 100% 100%
🟢
... / Netherlands.tsx
100% 100% 100% 100%
🟢
... / Pound.tsx
100% 100% 100% 100%
🟢
... / Spain.tsx
100% 100% 100% 100%
🟢
... / UK.tsx
100% 100% 100% 100%
🟢
... / Visa.tsx
100% 100% 100% 100%

Test suite run success

270 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from 98cf495

@nathanjamal nathanjamal self-assigned this Mar 21, 2023
@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

1 similar comment
@github-actions
Copy link

Compiled a new version demo.

@nathanjamal nathanjamal merged commit 437483a into main Mar 22, 2023
@nathanjamal nathanjamal deleted the HEYUI-276 branch March 22, 2023 10:02
supcar pushed a commit that referenced this pull request Mar 22, 2023
# [5.5.0](v5.4.0...v5.5.0) (2023-03-22)

### Features

* **icons:** added missing icons ([#172](#172)) ([437483a](437483a))
@supcar
Copy link
Collaborator

supcar commented Mar 22, 2023

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants