Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): the icon inside the button is centered #170

Merged
merged 8 commits into from
Mar 20, 2023

Conversation

esraltintas
Copy link
Contributor

The icon inside the button is centered

Pull Request

Description

The icon inside the button is centered
Screenshot 2023-03-16 at 18 42 32

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

The icon inside the button is centered
@esraltintas esraltintas self-assigned this Mar 16, 2023
@auto-assign auto-assign bot requested a review from nathanjamal March 16, 2023 17:43
@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@coveralls
Copy link

coveralls commented Mar 20, 2023

Pull Request Test Coverage Report for Build 4468986483

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 95.416%

Totals Coverage Status
Change from base Build 4439364139: 0.006%
Covered Lines: 1084
Relevant Lines: 1103

💛 - Coveralls

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Mar 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.7% 1192/1220
🟢 Branches 85.4% 269/315
🟢 Functions 94.79% 91/96
🟢 Lines 98.28% 1084/1103

Test suite run success

270 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from bf21217

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@esraltintas esraltintas merged commit d8d6d52 into main Mar 20, 2023
@esraltintas esraltintas deleted the feat/HEYUI-243 branch March 20, 2023 15:47
supcar pushed a commit that referenced this pull request Mar 20, 2023
# [5.3.0](v5.2.0...v5.3.0) (2023-03-20)

### Features

* **button:** the icon inside the button is centered ([#170](#170)) ([d8d6d52](d8d6d52))
@supcar
Copy link
Collaborator

supcar commented Mar 20, 2023

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants