Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): theme now sets base text size and color #159

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

nathanjamal
Copy link
Collaborator

@nathanjamal nathanjamal commented Mar 10, 2023

Pull Request

Description

The theme package will now set the base font-size and the default font color for any project its included in.
Because the text colour change, i've had to regenerate several screenshots

HEYUI-265

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

the theme package will now set the base font-size and the default font color for any project its
included in.

HEYUI-265
@auto-assign auto-assign bot requested a review from esraltintas March 10, 2023 14:16
@github-actions
Copy link

Compiled a new version demo.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4385365280

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.467%

Totals Coverage Status
Change from base Build 4374565054: 0.0%
Covered Lines: 1082
Relevant Lines: 1101

💛 - Coveralls

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.7% 1188/1216
🟢 Branches 85.53% 266/311
🟢 Functions 94.79% 91/96
🟢 Lines 98.27% 1082/1101

Test suite run success

273 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from 7ae9ebc

@nathanjamal nathanjamal self-assigned this Mar 10, 2023
@esraltintas esraltintas merged commit 8d946b2 into main Mar 10, 2023
@esraltintas esraltintas deleted the HEYUI-265 branch March 10, 2023 14:58
supcar pushed a commit that referenced this pull request Mar 10, 2023
# [4.6.0](v4.5.0...v4.6.0) (2023-03-10)

### Features

* **themes:** theme now sets base text size and color ([#159](#159)) ([8d946b2](8d946b2))
@supcar
Copy link
Collaborator

supcar commented Mar 10, 2023

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants