Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input): add number type to input's value type #145

Merged
merged 2 commits into from
Feb 27, 2023
Merged

feat(input): add number type to input's value type #145

merged 2 commits into from
Feb 27, 2023

Conversation

frankie303
Copy link
Contributor

@frankie303 frankie303 commented Feb 26, 2023 •
edited
Loading

Pull Request

Description

Added number type to input's value type

ticket: https://heycar.atlassian.net/browse/HEYUI-248

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@github-actions
Copy link

Compiled a new version demo.

@frankie303 frankie303 self-assigned this Feb 26, 2023
@coveralls
Copy link

coveralls commented Feb 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4275014600

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.467%
Totals Coverage Status
Change from base Build 4233939243: 0.0%
Covered Lines: 1082
Relevant Lines: 1101
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Feb 26, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 97.7% 1188/1216
🟢 Branches 85.53% 266/311
🟢 Functions 94.79% 91/96
🟢 Lines 98.27% 1082/1101

Test suite run success

273 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from f46f8e0

@frankie303 frankie303 marked this pull request as ready for review February 26, 2023 12:30
@github-actions
Copy link

Compiled a new version demo.

@esraltintas esraltintas merged commit 958915a into main Feb 27, 2023
@esraltintas esraltintas deleted the HEYUI-248-add-number-type-to-inputs-value-type branch February 27, 2023 08:57
supcar pushed a commit that referenced this pull request Feb 27, 2023
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
f5276a6 
# [4.3.0](v4.2.6...v4.3.0) (2023-02-27)

### Features

* **input:** add number type to input's value type ([#145](#145)) ([958915a](958915a))
@supcar
Copy link
Collaborator

supcar commented Feb 27, 2023

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

esraltintas pushed a commit that referenced this pull request Feb 27, 2023
@frankie303
feat(input): add number type to dropdown value type #145 (#146)
e00fdd9 
* feat(dropdown): add number type to dropdown's value type

* chore(package-lock.json): run npm i
supcar pushed a commit that referenced this pull request Feb 27, 2023
@semantic-release-bot
chore(release): 4.4.0 [skip ci]
8ff69eb 
# [4.4.0](v4.3.0...v4.4.0) (2023-02-27)

### Features

* **input:** add number type to dropdown value type [#145](#145) ([#146](#146)) ([e00fdd9](e00fdd9))
lucasmaffazioli pushed a commit that referenced this pull request Feb 28, 2023
@frankie303 @lucasmaffazioli
feat(input): add number type to input's value type (#145)
9dc0596 
* feat(input): add number type to input's value type

* chore(package-lock.json): run npm i
lucasmaffazioli pushed a commit that referenced this pull request Feb 28, 2023
@semantic-release-bot @lucasmaffazioli
chore(release): 4.3.0 [skip ci]
d1baf57 
# [4.3.0](v4.2.6...v4.3.0) (2023-02-27)

### Features

* **input:** add number type to input's value type ([#145](#145)) ([958915a](958915a))
lucasmaffazioli pushed a commit that referenced this pull request Feb 28, 2023
@frankie303 @lucasmaffazioli
feat(input): add number type to dropdown value type #145 (#146)
48f6ef1 
* feat(dropdown): add number type to dropdown's value type

* chore(package-lock.json): run npm i
lucasmaffazioli pushed a commit that referenced this pull request Feb 28, 2023
@semantic-release-bot @lucasmaffazioli
chore(release): 4.4.0 [skip ci]
810e6ca 
# [4.4.0](v4.3.0...v4.4.0) (2023-02-27)

### Features

* **input:** add number type to dropdown value type [#145](#145) ([#146](#146)) ([e00fdd9](e00fdd9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esraltintas esraltintas esraltintas approved these changes

@ayhansipahi ayhansipahi ayhansipahi approved these changes

@emrahsemizheycar emrahsemizheycar Awaiting requested review from emrahsemizheycar

@hcafaq hcafaq Awaiting requested review from hcafaq

@heyabinanto heyabinanto Awaiting requested review from heyabinanto

@pappjanos pappjanos Awaiting requested review from pappjanos

@nathanjamal nathanjamal Awaiting requested review from nathanjamal

@Arpitvicky Arpitvicky Awaiting requested review from Arpitvicky

Assignees

@frankie303 frankie303

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frankie303 @coveralls @supcar @ayhansipahi @esraltintas