Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): added input ref #141

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

hcafaq
Copy link
Contributor

@hcafaq hcafaq commented Feb 16, 2023

Pull Request

fix(dropdown): added input ref

Description

fix(dropdown): added input ref
Describe your changes (or add ticket description) and add relevant screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4193853571

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 95.333%

Totals Coverage Status
Change from base Build 4192952861: 0.004%
Covered Lines: 945
Relevant Lines: 964

💛 - Coveralls

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.73% 1033/1057
🟢 Branches 84.32% 199/236
🟢 Functions 92.86% 65/70
🟢 Lines 98.03% 945/964

Test suite run success

250 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from 93eac9b

@hcafaq hcafaq merged commit 424abfe into main Feb 16, 2023
@hcafaq hcafaq deleted the fix/add-input-ref-to-dropdown branch February 16, 2023 12:29
supcar pushed a commit that referenced this pull request Feb 16, 2023
## [4.2.3](v4.2.2...v4.2.3) (2023-02-16)

### Bug Fixes

* **dropdown:** added input ref ([#141](#141)) ([424abfe](424abfe))
@supcar
Copy link
Collaborator

supcar commented Feb 16, 2023

🎉 This PR is included in version 4.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants