feat(typography): Extend Typography component by allowing restProps #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
emrahsemizheycar,
esraltintas,
hcafaq,
heyabinanto and
pappjanos
|
Compiled a new version demo. |
hcafaq
reviewed
Feb 6, 2023
Pull Request Test Coverage Report for Build 4103467411
💛 - Coveralls |
Coverage report
Test suite run success250 tests passing in 37 suites. Report generated by 🧪jest coverage report action from ace825a |
Thanks @hcafaq. Just pushed an update. |
PriscillaSam
force-pushed
the
HEYUI-240-extend-the-typography-component-to-accept-sx-props
branch
from
2fd1dd8
to
ace825a
Compare
|
Compiled a new version demo. |
hcafaq
approved these changes
Feb 6, 2023
heyabinanto
approved these changes
Feb 6, 2023
PriscillaSam
deleted the
HEYUI-240-extend-the-typography-component-to-accept-sx-props
branch
supcar
pushed a commit
that referenced
this pull request
Feb 6, 2023
# [4.1.0](v4.0.1...v4.1.0) (2023-02-06) ### Features * **typography:** extend component by allowing restProps ([#135](#135)) ([2d34947](2d34947))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the Typography component by allowing restProps. This would enable styling fonts beyond using classNames.
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!