fix(grid column): fix the paddings #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
emrahsemizheycar,
esraltintas,
hcafaq,
heyabinanto and
pappjanos
frankie303
changed the title
Pull Request Test Coverage Report for Build 3855808612
💛 - Coveralls |
|
Compiled a new version demo. |
Coverage report
Test suite run success238 tests passing in 34 suites. Report generated by 🧪jest coverage report action from 2a4e1b1 |
esraltintas
approved these changes
Jan 6, 2023
esraltintas
approved these changes
Jan 6, 2023
emrahsemizheycar
approved these changes
Jan 6, 2023
heyabinanto
approved these changes
Jan 6, 2023
|
Compiled a new version demo. |
supcar
pushed a commit
that referenced
this pull request
Jan 6, 2023
## [3.2.3](v3.2.2...v3.2.3) (2023-01-06) ### Bug Fixes * **grid column:** fix the paddings ([#126](#126)) ([b73afae](b73afae))
|
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixed the not applying styling (padding-left / padding-right) for the Grid component.
Also, updated the screenshot tests.
JIRA ticket: https://heycar.atlassian.net/browse/HEYUI-217
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!