Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gaps): add 72px spacing to spacing variables #117

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

frankie303
Copy link
Contributor

@frankie303 frankie303 commented Nov 16, 2022

MTEC-2610

Pull Request

Description

Added a new spacing variable --gap-10xl which corresponds to 72px.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@github-actions
Copy link

Compiled a new version demo.

@coveralls
Copy link

coveralls commented Nov 16, 2022

Pull Request Test Coverage Report for Build 3479320239

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.088%

Totals Coverage Status
Change from base Build 3472925753: 0.0%
Covered Lines: 869
Relevant Lines: 872

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Nov 16, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 99.48% 951/956
🟢 Branches 90.23% 157/174
🟢 Functions 98.18% 54/55
🟢 Lines 99.66% 869/872

Test suite run success

238 tests passing in 34 suites.

Report generated by 🧪jest coverage report action from 4729618

@frankie303 frankie303 marked this pull request as ready for review November 16, 2022 12:26
@github-actions
Copy link

Compiled a new version demo.

@esraltintas esraltintas merged commit 37066cc into main Nov 17, 2022
@esraltintas esraltintas deleted the feat/MTEC-2610-add-72px-spacing branch November 17, 2022 08:35
supcar pushed a commit that referenced this pull request Nov 17, 2022
# [3.2.0](v3.1.3...v3.2.0) (2022-11-17)

### Features

* **gaps:** add 72px spacing to spacing variables ([#117](#117)) ([37066cc](37066cc))
@supcar
Copy link
Collaborator

supcar commented Nov 17, 2022

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants